I wrote

When specifying the partner of a vif, use the IP address of the partner interface, not the interface name.

Sigh... this is exactly backwards. As the man page (na_vif(1)) notes, use the interface name, not the address. Sorry for any confusion, and I promise not to skip that second cup of coffee before replying next time!

Sam